Explicit shutdown of TimerManager to ensure this is done on the main thread #54625
+33
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thread Summary: # Changelog [Internal] - It makes sense to explicitly shut down TimerManager instance to make sure that this is done from the place and thread it's intended to - otherwise, since lifetime of TimerManager instance is managed by a shared pointer, this can lead to situations, whereas some other thread retains the shared pointer and calls the shut down at some later stage, which can lead to all kinds of unintended consequences. Differential Revision: D87631467
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 2285512. |
Collaborator
|
This pull request was successfully merged by @rshest in 2285512 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog
[Internal] -
It makes sense to explicitly shut down TimerManager instance to make sure that this is done from the place and thread it's intended to - otherwise, since lifetime of TimerManager instance is managed by a shared pointer, this can lead to situations, whereas some other thread retains the shared pointer and calls the shut down at some later stage, which can lead to all kinds of unintended consequences.
Differential Revision: D87631467